Uh oh!
There was an error while loading. Please reload this page.
Improve sigchild compatibility and support explicit configuration - #63
Merged
Conversation
jsor
approved these changes
Nov 28, 2018
WyriHaximus
approved these changes
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves sigchild compatibility and adds support for explicit configuration in case automatic sigchild detection fails or the overhead incurred by the sigchild compatibility mode is not wanted. Note that this includes a small BC break because some of the old public sigchild methods have been removed, but its practical impact is believed to be relatively small due to the automatic detection.
Resolves / closes#60