Uh oh!
There was an error while loading. Please reload this page.
Test against PHP7.2 and PHP 7.3, improve HHVM compatibility and add forward compatibility with PHPUnit 7 - #66
Merged
Conversation
Additionally, use legacy PHPUnit 5 for legacy HHVM on Travis CI as per clue/socket-raw#42
jsor
approved these changes
Jan 9, 2019
clue
commented
Jan 9, 2019
MemberAuthor
I've just updated this to fix a number of minor HHVM incompatibilities introduced in recent commits via #65 that were undetected because HHVM builds didn't run anymore with recent PHPUnit versions (see Travis CI history). HHVM compatibility is not a high priority to me given HHVM has announced they are going to drop PHP support, but I figured it's worth fixing for now anyway. |
WyriHaximus
approved these changes
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, use legacy PHPUnit 5 for legacy HHVM on Travis CI as per
clue/socket-raw#42
Builds on top of #54