Uh oh!
There was an error while loading. Please reload this page.
[WIP] Run tests on Mac OS X and Windows on Travis CI - #70
Closed
clue wants to merge 2 commits into
Closed
Conversation
clue
commented
Jan 13, 2019
MemberAuthor
The Windows build works fine, the Mac OS X build currently fails due to a composer installation issue. I have already spent way to much time on this and I have no interest in chasing this down any further, so I've cherry-picked the Windows changes to #71 and will close this ticket for now. In case anybody feels like looking into the Mac OS X tests, I consider this PR to be a good starting point for a future PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Mac OS X and Windows to the test matrix on Travis CI. Most of this project should work cross-platform, but we've added some Windows-specifics with #67, so we have reason to believe that tests help us ensure we do not introduce any regressions in the future.
Both platforms are currently allowed to fail, given how we've tried to add similar tests in the past (#21 and #28) and also given that Windows platform support on Travis is currently considered "early release" (https://blog.travis-ci.com/2018-10-11-windows-early-release) and the test setup contains some workarounds. I consider this to be a first step and there's hope we can build on top of this in the future 👍
Builds on top of #67
Refs reactphp/stream#120 and reactphp/stream#112