Skip to content

chore(docs): remove leading dollar sign - #95

Merged
WyriHaximus merged 1 commit into
reactphp:0.6.xfrom
nhedger:chore/remove-leading-dollar
Jun 24, 2022
Merged

chore(docs): remove leading dollar sign#95
WyriHaximus merged 1 commit into
reactphp:0.6.xfrom
nhedger:chore/remove-leading-dollar

Conversation

@nhedger

@nhedgernhedger commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

@nhedgernhedger mentioned this pull request Jun 20, 2022
Merged
clue
clue reviewed Jun 20, 2022
View reviewed changes
Comment threadREADME.md Outdated
@clueclue added this to the v0.6.5 milestone Jun 20, 2022
@clue

clue commented Jun 20, 2022•
edited
Loading

Copy link
Copy Markdown
Member

The build error is unrelated to this changeset and is actually caused by an upstream regression in PHP 8.1.7 and PHP 8.0.20 only (see php/php-src#8575, php/php-src#8571 and php/php-src#8827). There's ongoing effort to revert this for upcoming PHP versions again, so the build should be green again by then, no changes required here.

@clue

clue commented Jun 21, 2022

Copy link
Copy Markdown
Member

The build error is unrelated to this changeset and is actually caused by an upstream regression in PHP 8.1.7 and PHP 8.0.20 only (see php/php-src#8575, php/php-src#8571 and php/php-src#8827). There's ongoing effort to revert this for upcoming PHP versions again, so the build should be green again by then, no changes required here.

See #96 for temporary test adjustments to skip affected tests.

clue
clue approved these changes Jun 21, 2022
View reviewed changes

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for the quick update, changes LGTM! 👍

@clue
clue requested a review from WyriHaximusJune 21, 2022 20:29
@WyriHaximus
WyriHaximus merged commit 127eadc into reactphp:0.6.xJun 24, 2022
@nhedger
nhedger deleted the chore/remove-leading-dollar branch June 24, 2022 09:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximusWyriHaximusWyriHaximus approved these changes
@clueclueclue approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v0.6.5

Development

Successfully merging this pull request may close these issues.

3 participants

@nhedger@clue@WyriHaximus