Uh oh!
There was an error while loading. Please reload this page.
Rename DatagramTransportExecutor to UdpTransportExecutor - #103
Merged
Conversation
WyriHaximus
approved these changes
Jun 25, 2018
jsor
approved these changes
Jun 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR renames the
DatagramTransportExecutor(recently introduced via #101) toUdpTransportExecutor. This is done to be in line with the DNS RFC terminology (https://tools.ietf.org/html/rfc1035#section-4.2), because it is less misleading (this class can only really support UDP) and also because for future TCP/IP transport the name "streaming" makes even less sense and they should be namedTcpTransportExecutor(#19) andTlsTransportExecutor(#80) respectively. I'm not marking this as BC break because this will be renamed as part of the same release, so outside consumers of this package should not be affected.