Uh oh!
There was an error while loading. Please reload this page.
Reuse TCP/IP socket connection and pipeline outgoing queries - #147
Merged
Conversation
clue
commented
Aug 9, 2019
MemberAuthor
Updated to work around failing test on legacy PHP 5.3 due to partly closed socket resource |
jsor
reviewed
Aug 10, 2019
Uh oh!
There was an error while loading. Please reload this page.
The TcpTransportExecutor will now keep the TCP/IP socket connection to the DNS server open for a short period. Additional queries can reuse the same socket connection and pipeline multiple queries over this single socket. This avoids creating multiple socket resources for concurrent requests and implies the TCP/IP connection overhead only applies once instead of for each query. Among others, this helps avoiding excessive resources and significantly improves query performance when using multiple (concurrent) queries. This implements RFC 7766 as per https://tools.ietf.org/html/rfc7766
jsor
approved these changes
Aug 11, 2019
WyriHaximus
approved these changes
Aug 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TcpTransportExecutor will now keep the TCP/IP socket connection to
the DNS server open for a short period. Additional queries can reuse the
same socket connection and pipeline multiple queries over this single
socket. This avoids creating multiple socket resources for concurrent
requests and implies the TCP/IP connection overhead only applies once
instead of for each query. Among others, this helps avoiding excessive
resources and significantly improves query performance when using
multiple (concurrent) queries.
This implements RFC 7766 as per https://tools.ietf.org/html/rfc7766
Builds on top of #145
Refs #19