Skip to content

Minor test clean up and skip failing test on HHVM - #165

Merged
jsor merged 1 commit into
reactphp:masterfrom
SimonFrings:tests
Jul 21, 2020
Merged

Minor test clean up and skip failing test on HHVM#165
jsor merged 1 commit into
reactphp:masterfrom
SimonFrings:tests

Conversation

@SimonFrings

Copy link
Copy Markdown
Member

No description provided.

@SimonFringsSimonFrings changed the title Skip failing test on HHVM and short clean upMinor test clean up and skip failing test on HHVMJul 20, 2020

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM 👍

@clue
clue requested review from WyriHaximus and jsorJuly 20, 2020 12:25
@clueclue added this to the v1.3.1 milestone Jul 20, 2020
@jsor
jsor merged commit 1f66dfd into reactphp:masterJul 21, 2020
@clueclue modified the milestones: v1.3.1, v1.4.0Sep 7, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SimonFrings@jsor@WyriHaximus@clue