Skip to content

Avoid dependency on ext-filter - #185

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:no-filter
Nov 26, 2021
Merged

Avoid dependency on ext-filter#185
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:no-filter

Conversation

@clue

@clueclue commented Nov 26, 2021

Copy link
Copy Markdown
Member

This simple changeset avoids an unneeded (and undeclared!) dependency on ext-filter. The extension is enabled by default, but can explicitly be disabled with --without-filter.

The code in question is already covered by the test suite, so the test suite confirms this changeset does not affect behavior or our public API in any way. Accordingly, this is entirely transparent for all consumers of this package, plus now also supports consumers that happen to use --without-filter.

See https://www.php.net/manual/en/filter.installation.php
Originally reported in leproxy/leproxy#80
Refs reactphp/socket#17

@clueclue added this to the v1.9.0 milestone Nov 26, 2021
@clue

clue commented Dec 6, 2021

Copy link
Copy Markdown
MemberAuthor

For future reference only: The error suppression operator is no longer required for PHP 7.3+, see https://3v4l.org/7T1kL

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@WyriHaximus