Uh oh!
There was an error while loading. Please reload this page.
Add TimeoutExecutor decorator - #48
Merged
Merged
Conversation
Merged
jsor
approved these changes
Feb 23, 2017
clue
commented
Mar 2, 2017
MemberAuthor
Rebased now that #47 is in |
clue
commented
Mar 2, 2017
MemberAuthor
Rebased again to fix new tests added via #45 |
jsor
commented
Mar 2, 2017
Member
@clue Are you planning to remove the |
clue
commented
Mar 2, 2017
MemberAuthor
@jsor Very likely, but not 100% decided yet. I'll make sure to set up a roadmap for this component soon 👍 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Executorviolates SRP, so this PR is a first step to break this up into multiple independent classes.This PR preserves full BC by making its timeout feature optional first and then using a
TimeoutExecutordecorator instead. This can also be reused for other components, in particular clue/mdns-react. Also, this is needed for upcoming changes related to #12 and #19 which will introduce new executor classes that will reuse this timeout handling.Builds on top of #35
Somewhat similar to reactphp-legacy/socket-client#51