Skip to content

Set bufferSize to null to fix Windows 10 timeout issue - #50

Closed
davidcole1340 wants to merge 6 commits into
reactphp:masterfrom
davidcole1340:master
Closed

Set bufferSize to null to fix Windows 10 timeout issue#50
davidcole1340 wants to merge 6 commits into
reactphp:masterfrom
davidcole1340:master

Conversation

@davidcole1340

Copy link
Copy Markdown

Fixes#44, not tested as I do not have a Windows 10 machine.

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but this is not supported on older Stream versions, so we should probably also lock the minimum Stream version to react/stream: ^0.4.5 👍

@WyriHaximus

Copy link
Copy Markdown
Member

@clue shouldn't that be ^0.5 || ^0.4.5 since we also support 0.5?

@WyriHaximusWyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawless on my Win10 desktop 👍

jsor
jsor approved these changes Mar 5, 2017

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not affect the socket version, but the stream version. I've cherry-picked the relevant changes for #53 instead 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@davidcole1340@WyriHaximus@jsor@clue