Uh oh!
There was an error while loading. Please reload this page.
Ensure we ignore the case of the answer - #51
Merged
WyriHaximus merged 2 commits intoMar 2, 2017
Merged
Conversation
clue
approved these changes
Feb 22, 2017
clue
left a comment
Member
There was a problem hiding this comment.
Nice find, which milestone should this target? 👍
| { | ||
| return array_filter($answers, function ($answer) use ($field, $value) { | ||
| return $value === $answer->$field; | ||
| return strtolower($value) === strtolower($answer->$field); |
Member
There was a problem hiding this comment.
Minor optimization: The left hand could probably be moved out of this callback.
WyriHaximus
commented
Feb 23, 2017
MemberAuthor
@clue next release makes most sense to me to set it to |
jsor
approved these changes
Feb 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came across this while working on #52, testing it against
blog.wyrihaximus.net(which is aCNAMEfor my blog hosted on amazon cloudfront) yieldedBlog.wyrihaximus.netas answer. The filter used in the resolver is case sensitive, this PR ensure's it isn't.