Skip to content

Documentation and examples for advanced usage - #66

Merged
jsor merged 3 commits into
reactphp:masterfrom
WyriHaximus-labs:advanced-usage
Aug 9, 2017
Merged

Documentation and examples for advanced usage#66
jsor merged 3 commits into
reactphp:masterfrom
WyriHaximus-labs:advanced-usage

Conversation

@WyriHaximus

Copy link
Copy Markdown
Member

Currently once can use the Executor directly to query but this isn't documented. This PR adds documentation and an example.

Comment threadREADME.md Outdated

## Advanced Usage

For more advanced usages one can utilize the `Executor` directly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to deprecate the Executor in future versions, so perhaps we should link to the whole namespace instead (may keep the below example in place though)?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating executor seems to be a good idea.

Comment threadREADME.md Outdated
* [Basic usage](#basic-usage)
* [Caching](#caching)
* [Custom cache adapter](#custom-cache-adapter)
* [Advanced usage](#advance-usage)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo here, otherwise LGTM 👍

clue
clue approved these changes Aug 9, 2017
@clueclue changed the title Advanced UsageDocumentation and examples for advanced usageAug 9, 2017
@clue

clue commented Aug 9, 2017

Copy link
Copy Markdown
Member

Changes LGTM, unrelated build error has been addressed via #68 in the meantime :shipit:

@clueclue added this to the v0.4.10 milestone Aug 9, 2017
jsor
jsor approved these changes Aug 9, 2017
@jsor
jsor merged commit af11e3c into reactphp:masterAug 9, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@WyriHaximus@clue@jsor@kelunik