Uh oh!
There was an error while loading. Please reload this page.
Resolver::resolveAll - #67
Conversation
| $factory = new Factory(); | ||
| $resolver = $factory->create('8.8.8.8', $loop); | ||
| $name = isset($argv[1]) ? $argv[1] : 'blog.wyrihaximus.net'; |
There was a problem hiding this comment.
In case anyone wonders why my own blog, because it is hosted on AWS CloudFront and this always returns more then one IP Address
There was a problem hiding this comment.
Maybe add that as a code comment rather than review comment.
| }); | ||
| } | ||
| public function extractAddress(Query $query, Message $response) |
There was a problem hiding this comment.
I agree here, while this method isn't intended to be used from the outside, it's still part of our (current) public API.
clue
left a comment
There was a problem hiding this comment.
Thanks, let's resolve the minor BC break below and let's get this in! 
| }); | ||
| } | ||
| public function extractAddress(Query $query, Message $response) |
There was a problem hiding this comment.
I agree here, while this method isn't intended to be used from the outside, it's still part of our (current) public API.
The status quo with the resolver is that
resolvewill always return oneIPaddress when resolving a hostname, even when the query response yields more. This proposedresolveAllmethod will return all addresses yielded from the query response.