UV Event Loop (PECL ext-uv) by WyriHaximus · Pull Request #112 · reactphp/event-loop

WyriHaximus · 2017-10-31T10:48:39Z

No description provided.

clue

Nice, would love to see more extensions find their way into this project! 👍

WyriHaximus · 2018-04-09T15:57:30Z

@clue @jsor right, rebased this PR against the latest master. Could you review?

…at reactphp#112 (comment)

@clue

… as suggested by @clue at reactphp#112 (comment)

…at reactphp#112 (comment)

@clue

… as suggested by @clue at reactphp#112 (comment)

@clue

…y as suggested by @clue at reactphp#112 (comment)

@clue

… off upwards as suggested by @clue at reactphp#112 (comment)

… at reactphp#112 (comment)

@clue

…ignal listeners attached for calling `uv_run`, modeled (copied) the bit from `ExtEvLoop` and had to rename $timerEvents to $timers (also makes more sense) as suggested by @clue at reactphp#112 (comment)

@clue

…nged and what failed before the change, as suggested by @clue at reactphp#112 (comment)

at reactphp#112 (comment)

…omment) The property was only used in one method and adding more bloat than solving a problem

…clue

…clue at reactphp#112 (comment)

WyriHaximus · 2018-12-10T21:39:05Z

@clue && @jsor && @cboden could you review this PR again. I feel it's ready to be merged and released into the wild 🎉 .

WyriHaximus · 2018-12-10T21:40:20Z

FYI the issues I was having wheren't related to the event loop directly but due to file descriptors being passed on child processed by default, solving that down/upstream depending on your perspective: WyriHaximus/reactphp-child-process-messenger#22

clue

@WyriHaximus added minor remarks only, can you squash this to a reasonable number of commits before the next review?

clue · 2019-01-11T15:17:31Z

+ if ($status !== 0) {
+ unset($this->flags[(int) $stream]);
+ $this->pollStream($stream);
+ }


Ping @WyriHaximus, what's the status here?

…at reactphp#112 (comment)

@clue

…#167, pointed out by @clue at reactphp#112 (comment)

WyriHaximus · 2019-01-11T18:46:38Z

@clue will squash into one commit once everyone approves it before merging it

…ctphp#112 (comment) and reactphp#112 (comment)

clue

It's happening: Squash and then let's get this in! 🎉

WyriHaximus · 2019-01-13T16:29:16Z

Ping @jsor && @cboden

WyriHaximus · 2019-01-13T20:33:24Z

It is time for this PR to be merged, I've squashed all commits into one, the original unrewritten history can be found here: https://github.com/WyriHaximus-labs/event-loop/tree/blacklight-history

WyriHaximus · 2019-01-13T20:39:38Z

WyriHaximus added the new feature label Oct 31, 2017

WyriHaximus added this to the v0.5.2 milestone Oct 31, 2017

WyriHaximus requested review from cboden, clue and jsor October 31, 2017 10:48

WyriHaximus force-pushed the blacklight branch 4 times, most recently from c6dcbde to 7a359c5Compare October 31, 2017 16:39

kelunik reviewed Oct 31, 2017
View reviewed changes

Comment threadsrc/Factory.php Outdated

kelunik reviewed Oct 31, 2017
View reviewed changes

Comment threadsrc/LibUvLoop.php Outdated

clue mentioned this pull request Nov 7, 2017
Consistent naming for EventLoop implementation #115
Closed

clue reviewed Nov 8, 2017
View reviewed changes

Comment threadsrc/LibUvLoop.php Outdated
Comment threadsrc/Factory.php Outdated
Comment threadtravis-init.sh Outdated

WyriHaximus force-pushed the blacklight branch from c20ff88 to 3722edaCompare November 13, 2017 21:20

clue changed the title ~~UV Event Loop~~UV Event Loop (unofficial ext-libuv)Dec 4, 2017

clue mentioned this pull request Dec 4, 2017
[WIP] LibUvLoop: Add new LibUvLoop (unofficial ext-libuv) #17
Closed

docteurklein reviewed Dec 15, 2017
View reviewed changes

Comment threadtests/AbstractLoopTest.php Outdated

WyriHaximus mentioned this pull request Feb 23, 2018
Support another EventLoop backend #152
Closed

WyriHaximus force-pushed the blacklight branch from a00ba1b to 066ada7Compare February 23, 2018 20:41

kelunik reviewed Feb 23, 2018
View reviewed changes

Comment threadsrc/Factory.php Outdated

WyriHaximus mentioned this pull request Feb 25, 2018
Support lib ev easily php-pm/php-pm#356
Closed

WyriHaximus force-pushed the blacklight branch from b525b0a to 5db28c5Compare March 13, 2018 13:31

WyriHaximus force-pushed the blacklight branch from 5db28c5 to 5d53564Compare April 9, 2018 15:30

WyriHaximus requested a review from clue April 9, 2018 15:56

clue requested changes Apr 24, 2018
View reviewed changes

clue modified the milestones: v0.5.2, v0.5.3 Apr 24, 2018

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Apr 24, 2018
Renamed LibUvLoop to ExtUvLoop after feedback from@clueand@kelunik…
b423bfe
…at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Apr 24, 2018
Aligned ext-uv detection method to check for the uv_loop_new function…
10545d9
… as suggested by @clue at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Renamed LibUvLoop to ExtUvLoop after feedback from@clueand@kelunik…
8dd9e08
…at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Aligned ext-uv detection method to check for the uv_loop_new function…
f20dde0
… as suggested by @clue at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Drop PHP 7 version check as the ext-uv loop only works on PHP 7 anywa…
ad0d2f7
…y as suggested by @clue at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Ensure intervals passed nto uv_timer_start are integers and rounded…
e9881a4
… off upwards as suggested by @clue at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Use different arrays for read and write listeners as suggested by@clue…
8db0f57
… at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Reverted a test timer change, can't remember of find why this was cha…
e5209e0
…nged and what failed before the change, as suggested by @clue at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Missing timer tests as pointed out by@clueatreactphp#112 (comment)
95b7634

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Install uv from PECL via@clueatreactphp#112 (comment)
f4d8132

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Updated readme and uv loop dockblock with it's release on PECL via@clue
94f4d7b
at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Removed the flags property as pointed out by@clueatreactphp#112 (c…
b390839
…omment) The property was only used in one method and adding more bloat than solving a problem

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Dec 10, 2018
Removed PHP 7 version check as ext-uv is only available for PHP 7 via@…
2aed93b
…clue at reactphp#112 (comment)

clue reviewed Jan 11, 2019
View reviewed changes

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Jan 11, 2019
Removed left over bug demonstration using travis, pointed out by@clue…
f517a17
…at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Jan 11, 2019
Ensure the new loop follows the standard set by@Ocramiusinreactphp…
0a67e3f
…#167, pointed out by @clue at reactphp#112 (comment)

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Jan 11, 2019
Ssuperfluous space, pointed out by@clueatreactphp#112 (comment)
b098273

ghost suggested changes Jan 11, 2019
View reviewed changes

Comment threadsrc/ExtUvLoop.php Outdated
Comment threadsrc/ExtUvLoop.php Outdated

WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Jan 11, 2019
Added missing space after type cast thanks to @CharlotteDunois atrea…
1e951a3
…ctphp#112 (comment) and reactphp#112 (comment)

clue approved these changes Jan 13, 2019
View reviewed changes

jsor approved these changes Jan 13, 2019
View reviewed changes

UV Event Loop
d589f9f

WyriHaximus force-pushed the blacklight branch from 5374439 to d589f9fCompare January 13, 2019 19:57

WyriHaximus removed the request for review from cboden January 13, 2019 20:33

WyriHaximus mentioned this pull request Feb 2, 2019
Create ext-uv adapter reactphp/filesystem#60
Closed

Uh oh!

Uh oh!

Conversation

WyriHaximus commented Oct 31, 2017

Uh oh!

Uh oh!

Uh oh!

clue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WyriHaximus commented Apr 9, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WyriHaximus commented Dec 10, 2018

Uh oh!

WyriHaximus commented Dec 10, 2018

Uh oh!

clue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clueJan 11, 2019

Choose a reason for hiding this comment

Uh oh!

WyriHaximus commented Jan 11, 2019

Uh oh!

Uh oh!

Uh oh!

clue left a comment

Choose a reason for hiding this comment

Uh oh!

WyriHaximus commented Jan 13, 2019

Uh oh!

WyriHaximus commented Jan 13, 2019

Uh oh!

WyriHaximus commented Jan 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants