Uh oh!
There was an error while loading. Please reload this page.
Allow throwing Exception if stream resource is not supported - #158
Merged
Conversation
WyriHaximus
approved these changes
Mar 26, 2018
jsor
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This very simple PR adds documentation to make consumers aware that
addReadStream()andaddWriteStream()MAY throw anExceptionif the given stream resource type is not supported by the underlying event loop implementation. This is explicitly not enforced due to performance considerations, so consumers SHOULD NOT rely on this.Builds on top of #110