Skip to content

Add .gitattributes to exclude dev files from exports - #201

Merged
clue merged 1 commit into
reactphp:masterfrom
reedy:gitattributes
Dec 21, 2019
Merged

Add .gitattributes to exclude dev files from exports#201
clue merged 1 commit into
reactphp:masterfrom
reedy:gitattributes

Conversation

@reedy

@reedyreedy commented Dec 1, 2019

Copy link
Copy Markdown
Contributor

As per discussion at reactphp/promise#153

@reedyreedy changed the title Create .gitattributesAdd .gitattributes to exclude dev files from exportsDec 1, 2019
@WyriHaximusWyriHaximus added this to the v1.1.1 milestone Dec 2, 2019
clue
clue approved these changes Dec 2, 2019

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedy Changes LGTM, unrelated build error is being addressed in #202:shipit:

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedy Just noticed that the travis-init.sh is missing, can you add/amend this 👍

@WyriHaximusWyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@clue
clue merged commit f331f95 into reactphp:masterDec 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@reedy@jsor@WyriHaximus@clue