Uh oh!
There was an error while loading. Please reload this page.
Test on PHP 8.2 - #258
Merged
Merged
Conversation
WyriHaximusforce-pushed
the
1.x-test-on-8.2
branch
from
August 13, 2022 14:01
644d2bc to
70a7401CompareWyriHaximus
commented
Aug 13, 2022
MemberAuthor
In order to finish this PR phpspec/prophecy#556 needs to be resolved. Or we need to consider one of the solutions in the issue. I'll file this PR onto our other packages as well, including the |
WyriHaximusforce-pushed
the
1.x-test-on-8.2
branch
from
August 13, 2022 22:15
8daa444 to
7c4995fCompareWyriHaximusforce-pushed
the
1.x-test-on-8.2
branch
from
August 23, 2022 06:37
7c4995f to
70a7401CompareWyriHaximus added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus
marked this pull request as ready for review
August 23, 2022 06:39
WyriHaximus added a commit
to WyriHaximus-secret-labs/stream
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/child-process
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-secret-labs/promise-timer
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/cache
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/socket
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/datagram
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/promise-stream
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-secret-labs/promise
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-secret-labs/promise
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
WyriHaximus added a commit
to WyriHaximus-labs/async
that referenced
this pull request
Aug 23, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
This was referenced Aug 23, 2022
This was referenced Aug 23, 2022
WyriHaximus added a commit
to WyriHaximus-labs/filesystem
that referenced
this pull request
Aug 25, 2022
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
This was referenced Aug 31, 2022
SimonFrings
commented
Jan 3, 2023
Member
@WyriHaximus wanted to ask what the current status of this PR is. I remember seeing some deprecation notices last time I checked, but I can't see them anymore. Maybe it fixed itself in the meantime :D |
WyriHaximus
commented
Jan 3, 2023
MemberAuthor
@SimonFrings Good question, will force push to find out |
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.
WyriHaximusforce-pushed
the
1.x-test-on-8.2
branch
from
January 3, 2023 18:43
70a7401 to
de07690CompareWyriHaximus
commented
Jan 3, 2023
MemberAuthor
@SimonFrings All green now 🎉 |
SimonFrings
commented
Jan 4, 2023
Member
@WyriHaximus Nice, just noticed the warnings for ext-event with PHP 8+. Nothing you caused with this PR, this is why I'd say we merge this as is and look into these warnings in a follow up PR. We should also keep in mind that |
SimonFrings
approved these changes
Jan 4, 2023
WyriHaximus
commented
Jan 4, 2023
MemberAuthor
@SimonFrings Sounds like a plan, thought we already updated all ubuntu runners, to be honest. |
clue
approved these changes
Jan 5, 2023
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the patience, changes LGTM! 
Agree with @SimonFrings that the test warnings seem to be unrelated to this PR and should be fixed in a separate PR. I've started looking into this in November and will try to get this ready in the next couple of days (refs reactphp/socket#300). 👍
lucasnetau pushed a commit
to lucasnetau/react-dns
that referenced
this pull request
Jun 30, 2023
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it. Refs: reactphp/event-loop#258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.