Skip to content

Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2 - #279

Merged
WyriHaximus merged 1 commit into
reactphp:3.xfrom
PaulRotmann:PHP8.4
Jul 24, 2025
Merged

Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2#279
WyriHaximus merged 1 commit into
reactphp:3.xfrom
PaulRotmann:PHP8.4

Conversation

@PaulRotmann

Copy link
Copy Markdown
Contributor

Builds on top of #269, #270 and reactphp/socket#323.
Also had to remove ext-ev from default extensions, install it explicitly based on PHP version.

Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml
Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml Outdated
@PaulRotmann

Copy link
Copy Markdown
ContributorAuthor

I refactored the CI workflow using a new approach with a ternary expression to conditionally include the appropriate ev extension version based on PHP. This greatly simplified the setup and made many of the previous redundant changes unnecessary.

The tests now run cleanly in GitHub Actions with ev installed properly on all targeted PHP versions. Thanks for the feedback, happy to adjust further if needed!

@clueclue added this to the v3.0.0 milestone Jul 23, 2025

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulRotmann Thanks for the update, changes look much cleaner now, all LGTM 👍

@WyriHaximus
WyriHaximus merged commit 2a20bf3 into reactphp:3.xJul 24, 2025
26 checks passed
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 14, 2025
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 23, 2025
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 23, 2025
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 25, 2025
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PaulRotmann@WyriHaximus@clue