Uh oh!
There was an error while loading. Please reload this page.
Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2 - #279
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
PaulRotmann
commented
Jul 22, 2025
I refactored the CI workflow using a new approach with a ternary expression to conditionally include the appropriate ev extension version based on PHP. This greatly simplified the setup and made many of the previous redundant changes unnecessary. The tests now run cleanly in GitHub Actions with ev installed properly on all targeted PHP versions. Thanks for the feedback, happy to adjust further if needed! |
clue
left a comment
There was a problem hiding this comment.
@PaulRotmann Thanks for the update, changes look much cleaner now, all LGTM 👍
Uh oh!
There was an error while loading. Please reload this page.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of #269, #270 and reactphp/socket#323.
Also had to remove ext-ev from default extensions, install it explicitly based on PHP version.