Uh oh!
There was an error while loading. Please reload this page.
[1.x] Improve PHP 8.5+ support by avoiding deprecated method calls - #282
Merged
Conversation
This code introduced in reactphp#196 relied on behavior that has been changed in PHP8.5 by: https://wiki.php.net/rfc/warnings-php-8-5#casting_out_of_range_floats_to_int
In PHP8.1 ReflectionProperty::setAccessible was made a no-op through https://wiki.php.net/rfc/make-reflection-setaccessible-no-op in PHP8.5 it is now throwing a deprecation warning by: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible
WyriHaximusforce-pushed
the
1.x-php-8.5
branch
from
November 10, 2025 14:57
abb89a1 to
d238022CompareIn PHP8.5 the SplObjectStorage::contains, SplObjectStorage::attach, and SplObjectStorage::detach methods have been deprecated through https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_splobjectstoragecontains_splobjectstorageattach_and_splobjectstoragedetach
clue
approved these changes
Nov 17, 2025
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 11, 2026
This was referenced Jan 24, 2026
This was referenced Feb 21, 2026
This was referenced Apr 12, 2026
Merged
This was referenced Jun 6, 2026
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP8.5 by running against PHP8.5 on CI and ensuring the code is compatible with PHP8.5.
Builds on #280, #196, and many others.