Fix for PHP 7 fatal error on duplicate parameter names in closures

[ondrejmirtes]

PHP 7 does not like duplicate parameter names: https://3v4l.org/usQhl

[ondrejmirtes]

The build failed on PHP 5.5 because the composer.json requires PHPUnit version that requires PHP 5.6.

[WyriHaximus]

That is interesting because the 5.4 build didn't fail. We don't specify phpunit in composer.json, the phpunit versions are supplied by travis

[clue]

The changes LGTM and make perfect sense 👍

Though I'm a bit surprised, has #27 been solved yet? Afaict nobody has managed to build the required extensions, so this code will not actually run? (Only the StreamSelectLoop should work)

[dakota]

Event 2.0 has been released with full PHP7 support. What is needed to get this to be merged?

[ondrejmirtes]

We are already using PECL event 2.0 extension with PHP 7.0.3 with this patch and everything works fine.

[dakota]

@ondrejmirtes I'm busy patching our local install. Wondering when this will end up in a event-loop release.

[ondrejmirtes]

I will contact ReactPHP maintainers in order to ask them what can we do to bring ReactPHP up to speed.

[cebe]

#45 includes this fix and adds also tests for php 7.

[clue]

Wondering when this will end up in a event-loop release.

At the moment the above changes are not tested in our CI setup. I assume this will be accepted once we come up with some installation instructions for the required extensions, so perhaps anybody may help with #27 or #45?

[cebe]

@clue#45 is ready to merge. libev and libevent do not support php7 so there is nothing to fix from our side atm.

[cboden]

Merged in via #45