StreamSelectLoop: Test suite uses signal constant names in data provider

[ghost]

Define constants SIGUSR1, SIGHUP and SIGTERM if they are not defined yet. The signal constants are used in data provider StreamSelectLoopTest::signalProvider() and cause a notice when the pcntl extension is not loaded.

Notice: Use of undefined constant SIGUSR1 - assumed 'SIGUSR1'

[clue]

I'm currently undecided so I won't vote yet. Can we really pass values for these missing constants or should we rather make sure the tests are skipped in this case?

[ghost]

The tests are skipped when pcntl is not loaded. The problem is that the constants are used in a data provider and PHPUnit will allways call the data provider before the test is skipped from within.

An alternative solution would be to do the checks in the data provider and provide defaults. This way one can get rid of notices without defining constants.

[clue]

IMHO it makes more sense to make sure the data provider is only invoked if the extension is actually available. If this is not possible, then I would suggest using signal constant names only and accessing values only through the constant() function.

What do you think?

[ghost]

Using constant() still triggers a warning:

Warning: constant(): Couldn't find constant SIGUSR1

I changed the code to do the checks in the data provider. I am not aware of any way to prevent the data provider from being called by PHPUnit. Another solution would be to do the signal testing in another test class and do the check in the setup method but that is too much work IMHO.

[jsor]

From the PHPUnit docs (second blue box):

All data providers are executed before both the call to the setUpBeforeClass static method and the first call to the setUp method. Because of that you can't access any variables you create there from within a data provider. This is required in order for PHPUnit to be able to compute the total number of tests.

https://phpunit.de/manual/current/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.data-providers.examples.DependencyAndDataProviderCombo.php

Also related: sebastianbergmann/phpunit#836

This current solution looks like a good compromise, so i'm 👍

[jsor]

I've recently run into the same while running the test suite on windows, so 👍

[clue]

Looks okay to me, but consider my comment below anyway 👍

[clue]

This looks okay to me. My suggestion would have been to only return the constant names here and then use constant() to access their values within the test instead. This way we would not have to provide any defaults at all and could still skip the tests (possibly via defined()). What do you think about this?

[clue]

Ping @martinschroeder, what do you think about the above suggestion?

Also, may I ask you to rebase this on the new "0.4" branch so we get this in for the upcoming v0.4.3 release?

[clue]

I've updated the base branch, can you force-push a rebased version? 👍

[ghost]

I rebased the PR and changed the data provider to use signal constant names as suggested.