Uh oh!
There was an error while loading. Please reload this page.
Run tests on Windows using AppVeyor (backported to v0.4) - #78
Conversation
clue
commented
Feb 13, 2017
@WyriHaximus Do the build errors on AppVeyor make any sense to you? Should this be fixed here or should we just accept this despite the build errors? |
WyriHaximus
commented
Feb 13, 2017
@clue no clue, it's windows so it fails at times sadly enough. But you could try restarting the build. The JSON parse errors or very vague. You could remove the cache directive or change it to |
clue
commented
Feb 13, 2017
I've now triggered a rebuild several times already, but the build keeps failing at different places all the time... 😕 |
WyriHaximus
commented
Feb 13, 2017
Gah 😕 |
clue
commented
Feb 13, 2017
If you look at the build history, you'll see that EVERY build failed, except the one where you've added AppVeyor :-) It even failed merging these changes to the master branch. https://ci.appveyor.com/project/clue/event-loop/history What should we do here? Not a big fan of marking working code as broken, so we should either look into fixing this ASAP or remove AppVeyor again? |
WyriHaximus
commented
Feb 13, 2017
Looks like |
jsor
commented
Feb 13, 2017
I've have absolutely no idea what's going on there and as long as we don't have someone who can reliably maintain the AppVeyor configuration, i'd vote for removing it alltogether. |
WyriHaximus
commented
Feb 13, 2017
My main reason for doing this was #71 and if we can't do that reliable we should indeed remove it. For personal projects I have less of an issue with failing some jobs on windows. But for react we can't afford that because it's time consuming to baby sit all the builds. |
clue
commented
Feb 13, 2017
I have to agree here 👍 I'd rather test on Windows manually and fix any issues as they occur. FWIW, AppVeyor did NOT help reproducing the error from #71, it actually passed, so... @WyriHaximus Can you file a PR that supersedes this and #76? |
Backported #76 (originally by @WyriHaximus) to the v0.4 release branch so that tests also work here.