Uh oh!
There was an error while loading. Please reload this page.
StreamSelectLoop: Fix erroneous zero-time sleep (2) - #93
Merged
Conversation
jsor
reviewed
Apr 3, 2017
| public function testSmallTimerInterval() | ||
| { | ||
| /** @var StreamSelectLoop|\PHPUnit_Framework_MockObject_MockObject $loop */ | ||
| $loop = $this->getMock(StreamSelectLoop::class, ['streamSelect']); |
clue
approved these changes
Apr 3, 2017
clue
left a comment
Member
There was a problem hiding this comment.
Much appreciated! LGTM and should eventually also be cherry-picked to the v0.4.3 release branch 👍
ivkalita
commented
Apr 4, 2017
ContributorAuthor
@clue, @jsor, @WyriHaximus, thank you! :) |
This was referenced Apr 4, 2017
jsor
commented
Apr 4, 2017
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving #48.