Uh oh!
There was an error while loading. Please reload this page.
Forward compatibility with react/event-loop 1.0 and 0.5 while still supporting 0.4 - part deux - #36
Conversation
| if (!interface_exists('React\EventLoop\TimerInterface') && interface_exists('React\EventLoop\Timer\TimerInterface')) { | ||
| class_alias('React\EventLoop\Timer\TimerInterface', 'React\EventLoop\TimerInterface'); | ||
| } |
There was a problem hiding this comment.
That's an interesting one :-) That being said, it can probably be removed once the other remark is addressed 👍
| use Evenement\EventEmitterTrait; | ||
| use React\EventLoop\Timer\TimerInterface; | ||
| use React\EventLoop\TimerInterface; |
There was a problem hiding this comment.
We can probably remove this import entirely. It is only used once in https://github.com/WyriHaximus-labs/filesystem/blob/9d5487ab7285843e899f5e7039f3cf6602044c07/src/Node/Directory.php#L261 where it can also be omitted. In fact, https://github.com/WyriHaximus-labs/filesystem/blob/9d5487ab7285843e899f5e7039f3cf6602044c07/src/Node/Directory.php#L263 appears to be untested and will not work with the newest EventLoop.
WyriHaximus
commented
Jul 4, 2018
@clue updated the PR removing all usages of TimerInterface |
ad495da to
de26616Comparede26616 to
a58e71dCompare…upporting 0.4 - part deux
a58e71d to
6aeed57CompareWyriHaximus
commented
Jul 6, 2018
Rebased everything into one commit |
Jumped the gun with #35 and in my enthusiasm I forgot to add the required code changes. This PR adds those missing changes. My apologies