Uh oh!
There was an error while loading. Please reload this page.
Remove guzzle parser - #26
Conversation
There was a problem hiding this comment.
IMO I think it would be better if $value was always an array. This would prevent the consumer from having to type check.
cboden
commented
May 1, 2015
A good start! Off the top of my head this is also a valid multi value header:
|
hiend
commented
May 1, 2015
hmm, values may contain comma for a different reasons:
|
WyriHaximus
commented
May 1, 2015
Aren't header values seperated by |
hiend
commented
May 1, 2015
github response :) |
WyriHaximus
commented
May 1, 2015
👍 Also we would very highly appreciate unit tests. |
There was a problem hiding this comment.
Not sure about the pinning down on 1.0. Using it to talk to 1.1 servers a lot and that works fine. Not sure what their responses are but blocking 1.1 responses while they used to work in previous 0.4.x versions could be a BC break. Will investigate for you :).
WyriHaximus
commented
Aug 22, 2015
I'm closing this issue in favor of #34. You've done a great job but after @cbodenreactphp/http#29 I've realized that using an external package that is specialized in message parsing is the better way to go. Your work is much appreciated and this decision isn't because of the work you've put into it. Once again thank you 👍 |
Simple response parser