Uh oh!
There was an error while loading. Please reload this page.
Send HTTP status code 431 if request header is too large - #126
Merged
Conversation
clue
commented
Feb 19, 2017
MemberAuthor
Rebased now that #125 is in |
jsor
approved these changes
Feb 19, 2017
WyriHaximus
approved these changes
Feb 20, 2017
WyriHaximus
left a comment
Member
There was a problem hiding this comment.
Looks good but could you fix merge conflicts?
MemberAuthor
Rebased now that #127 is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, sending an invalid request results in the same error message as sending a valid request that is too large:
HTTP/1.1 400 Bad Request.This simple PR change it so that the latter will now use the more descriptive error message:
HTTP/1.1 431 Request Header Fields Too LargeBuilds on top of #124