Skip to content

Response closes after forwarding close event - #131

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:response-close
Feb 21, 2017
Merged

Response closes after forwarding close event#131
WyriHaximus merged 1 commit into
reactphp:masterfrom
clue-labs:response-close

Conversation

@clue

@clueclue commented Feb 21, 2017

Copy link
Copy Markdown
Member

The Response now follows normal stream event semantics and actually closes after forwarding the close event. In the same vein, writing after an end() or close() is now a NOOP as expected.

Refs #104
Refs #130

@clueclue added this to the v0.6.0 milestone Feb 21, 2017
@clueclue mentioned this pull request Feb 21, 2017
Merged
@clueclue mentioned this pull request Feb 21, 2017
Merged
WyriHaximus
WyriHaximus approved these changes Feb 21, 2017
View reviewed changes

@WyriHaximusWyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus
WyriHaximus merged commit 4468182 into reactphp:masterFeb 21, 2017
@clue
clue deleted the response-close branch February 22, 2017 14:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsorjsorjsor approved these changes
@WyriHaximusWyriHaximusWyriHaximus approved these changes

Assignees

No one assigned

Labels

new feature

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus