Skip to content

Forward compatibility with Stream v1.0 and v0.7 - #184

Merged
WyriHaximus merged 2 commits into
reactphp:masterfrom
clue-labs:stream
May 15, 2017
Merged

Forward compatibility with Stream v1.0 and v0.7#184
WyriHaximus merged 2 commits into
reactphp:masterfrom
clue-labs:stream

Conversation

@clue

@clueclue commented May 13, 2017

Copy link
Copy Markdown
Member

Builds on top of #183

@clue

clue commented May 15, 2017

Copy link
Copy Markdown
MemberAuthor

Updated to simplify buffering tests by using new react/promise-stream release :shipit:

@WyriHaximus

Copy link
Copy Markdown
Member

@clue changes look good, but any idea why the lowest builds are failing?

@clue

clue commented May 15, 2017

Copy link
Copy Markdown
MemberAuthor

@WyriHaximus Updated the first commit to target at least react/stream v0.4.6 which contains a bugfix for the ThroughStream that is now used in the test suite :shipit:

@WyriHaximus

Copy link
Copy Markdown
Member

Cheers 👍

@WyriHaximus
WyriHaximus merged commit 01332ae into reactphp:masterMay 15, 2017
@clue
clue deleted the stream branch May 15, 2017 22:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@WyriHaximus@jsor