Skip to content

Avoid unneeded warning when decoding invalid data on PHP 7.4 - #357

Merged
jsor merged 1 commit into
reactphp:masterfrom
WyriHaximus-labs:php-7.4
Jan 12, 2020
Merged

Avoid unneeded warning when decoding invalid data on PHP 7.4#357
jsor merged 1 commit into
reactphp:masterfrom
WyriHaximus-labs:php-7.4

Conversation

@WyriHaximus

@WyriHaximusWyriHaximus commented Jan 11, 2020

Copy link
Copy Markdown
Member

Supersedes / Closes#356
Refs: reactphp/http-client#150

@WyriHaximusWyriHaximus added this to the v0.8.6 milestone Jan 11, 2020
@WyriHaximus
WyriHaximus requested review from clue and jsorJanuary 11, 2020 20:40
Comment thread.travis.yml Outdated
Comment thread.travis.yml

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPUnit 7+ reports a warning due to unsupported XML definition, otherwise LGTM 👍

Comment thread.travis.yml
@WyriHaximus
WyriHaximus requested a review from clueJanuary 12, 2020 12:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@jsor@clue