Skip to content

Drop array as possible request handler - #362

Merged
jsor merged 1 commit into
reactphp:masterfrom
WyriHaximus-labs:drop-array-as-possible-request-handler
Jul 10, 2020
Merged

Drop array as possible request handler#362
jsor merged 1 commit into
reactphp:masterfrom
WyriHaximus-labs:drop-array-as-possible-request-handler

Conversation

@WyriHaximus

Copy link
Copy Markdown
Member

Instead use variadics and turn any callable added after the event loop
as constructor argument into a middleware and use the last one as
request handler.

Due to the use of variadic the minimum PHP version has been bumped to
5.6.

Builds on #361

@WyriHaximus
WyriHaximus requested review from clue and jsor and removed request for clueJune 24, 2020 16:50
@WyriHaximusWyriHaximus added this to the v0.9.0 milestone Jun 24, 2020
@WyriHaximus
WyriHaximus requested a review from clueJune 24, 2020 19:55
@clueclue modified the milestones: v0.9.0, v1.0.0Jun 28, 2020
Comment threadREADME.md
Instead use func_get_args() and turn any callable added after the event
loop as constructor argument into a middleware and use the last one as
request handler.
clue
clue approved these changes Jul 9, 2020

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! :shipit:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@jsor@clue