Skip to content

Move Response class to React\Http\Message\Response and ServerRequest class to React\Http\Message\ServerRequest - #370

Merged
WyriHaximus merged 4 commits into
reactphp:masterfrom
clue-labs:message
Jul 10, 2020
Merged

Move Response class to React\Http\Message\Response and ServerRequest class to React\Http\Message\ServerRequest#370
WyriHaximus merged 4 commits into
reactphp:masterfrom
clue-labs:message

Conversation

@clue

@clueclue commented Jul 9, 2020

Copy link
Copy Markdown
Member

This changeset moves the Response class to React\Http\Message\Response and the ServerRequest class to React\Http\Message\ServerRequest. The Response class is used throughout our examples and user code, the ServerRequest class used to be internal only and is now exposed (testing client web applications).

// old$response = newReact\Http\Response(200, [], 'Hello!');
// new$response = newReact\Http\Message\Response(200, [], 'Hello!');

Builds on top of #361 and #368

@clueclue added this to the v1.0.0 milestone Jul 9, 2020
Comment threadtests/benchmark-middleware-runner.php Outdated
jsor
jsor approved these changes Jul 9, 2020
@clue
clue requested a review from WyriHaximusJuly 9, 2020 21:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus