Skip to content

Introduce using PSR-7 HTTP Status code constants - #406

Closed
WyriHaximus wants to merge 1 commit into
reactphp:masterfrom
WyriHaximus-labs:introduce-http-status-code-constants
Closed

Introduce using PSR-7 HTTP Status code constants#406
WyriHaximus wants to merge 1 commit into
reactphp:masterfrom
WyriHaximus-labs:introduce-http-status-code-constants

Conversation

@WyriHaximus

@WyriHaximusWyriHaximus commented Apr 12, 2021

Copy link
Copy Markdown
Member

Introducing using these constants makes it easier to identify a
specific HTTP status used in our code. And for our users to use
readable status codes in their own code.

@WyriHaximusWyriHaximus added this to the v1.4.0 milestone Apr 12, 2021
@WyriHaximus
WyriHaximus requested review from clue and jsorApril 12, 2021 21:23
@jsor

jsor commented Apr 20, 2021

Copy link
Copy Markdown
Member

Would it make sense to use constants from Fig\Http\Message\StatusCodeInterface?

@WyriHaximus

Copy link
Copy Markdown
MemberAuthor

@jsor How did I not know those are out there?! Updating the PR now

@WyriHaximusWyriHaximus changed the title Introduce HTTP Status code constantsIntroduce using PSR-7 HTTP Status code constantsApr 21, 2021
Introducing using these constants makes it easier to identify a
specific HTTP status used in our code. And for our users to use
readable status codes in their own code.
@clueclue modified the milestones: v1.4.0, v1.5.0Jul 10, 2021
@clueclue removed this from the v1.5.0 milestone Aug 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@jsor@clue