Skip to content

Rename Server to HttpServer to avoid class name collisions and ambiguities - #417

Merged
WyriHaximus merged 2 commits into
reactphp:masterfrom
clue-labs:httpserver
Jul 27, 2021
Merged

Rename Server to HttpServer to avoid class name collisions and ambiguities#417
WyriHaximus merged 2 commits into
reactphp:masterfrom
clue-labs:httpserver

Conversation

@clue

@clueclue commented Jul 25, 2021

Copy link
Copy Markdown
Member

This changeset renames the Server class to HttpServer to avoid class name collisions and ambiguities.

// deprecated$server = newReact\Http\Server($handler);
$server->listen(newReact\Socket\Server($port));
// new$http = newReact\Http\HttpServer($handler);
$http->listen(newReact\Socket\Server($port));

The deprecated Server is now an alias for new HttpServer to ensure existing code continues to work as-is.

Comment threadsrc/Server.php Outdated
Comment threadsrc/Server.php Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@WyriHaximus