Uh oh!
There was an error while loading. Please reload this page.
Improve assigning Content-Length for 304 Not Modified response - #430
Merged
Conversation
SimonFrings
approved these changes
Nov 5, 2021
clue
commented
Nov 7, 2021
MemberAuthor
Rebased on |
WyriHaximus
approved these changes
Nov 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset ensures we preserve any explicit
Content-Lengthresponse headers and do not assign aContent-Length: 0by default for a304 Not Modifiedresponse.Builds on top of #429, #188 and #156
Refs tornadoweb/tornado#1736 and ninenines/cowboy#1153