Uh oh!
There was an error while loading. Please reload this page.
Improve multipart limits test - #491
Merged
clue merged 1 commit intoApr 14, 2023
Merged
Conversation
The PR introducing this test assumed time would be enough to accurately predict behavior. This commit changes it to using introspection to check the exact state of the parser and expected state once finished parsing a multipart request body. To accomplish that it was required to make the cursor in the file an object property, so it can be inspected using reflection.
WyriHaximusforce-pushed
the
1.x-improve-multipart-limits-test
branch
from
March 2, 2023 15:55
b33cd9f to
2942434CompareSimonFrings
approved these changes
Apr 14, 2023
clue
approved these changes
Apr 14, 2023
clue
left a comment
Member
There was a problem hiding this comment.
Not exactly the most beautiful changeset, but it's an improvement over the previous version, so… 
Thanks @WyriHaximus!
WyriHaximus
commented
Apr 16, 2023
MemberAuthor
Done worse and done better, not proud of it but gets the job done 🖖 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introducing this test assumed time would be enough to accurately predict behavior. This commit changes it to using introspection to check the exact state of the parser and expected state once finished parsing a multipart request body. To accomplish that it was required to make the cursor in the file an object property, so it can be inspected using reflection.