Uh oh!
There was an error while loading. Please reload this page.
HTTP client: Fix empty streaming request body, omit Transfer-Encoding: chunked - #516
Merged
Merged
Conversation
SimonFrings
approved these changes
Feb 23, 2024
SimonFrings
left a comment
Member
There was a problem hiding this comment.
Looks good to me, let's get this in 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes sending an outgoing streaming request body that is known to be empty. In this case, we do not want to send a
Content-Length: 0orTransfer-Encoding: chunked. Prior to this change, we would send aTransfer-Encoding: chunkedheader without ever sending an end chunk, thus never signalling the end of the request body stream to the HTTP server. In other words, the updated version is now compliant with https://www.rfc-editor.org/rfc/rfc9112.html.Resolves#497