Uh oh!
There was an error while loading. Please reload this page.
Fix checking maximum header size, do not take start of body into account - #88
Conversation
clue
commented
Feb 5, 2017
Thanks for filing this PR 👍 Unfortunately it has no tests, see also #82. |
WyriHaximus
left a comment
There was a problem hiding this comment.
As @clue mentions could you add tests?
| }); | ||
| $parser->on('error', function($exception) { | ||
| $this->emit('error', [$exception]); | ||
| }); |
There was a problem hiding this comment.
Not sure why this is in this PR? (It does make sense to do this non the less.)
5fb8f9e to
c4c1aecCompareadded test removed bubble up of error from Server.php, not related to this issue |
WyriHaximus
commented
Feb 5, 2017
Test look good, but now this test is failing
Great, thanks 👍 |
6e3c57d to
97ac89cCompare| $data = $this->createGetRequest(); | ||
| $data = str_pad($data, 4096 * 4); | ||
| $data = chop($this->createGetRequest()); |
There was a problem hiding this comment.
This looks okay, but could probably be a bit clearer. What do you think, should this be updated to use a literal request string here instead?
There was a problem hiding this comment.
I agree, thanks for the suggestion.
97ac89c to
5dc78e7Compare
Fixed check for exceeding maximum header size in RequestHeaderParser::feed()