Skip to content

Add documentation - #16

Merged
clue merged 2 commits into
masterfrom
readme
Jul 5, 2015
Merged

Add documentation#16
clue merged 2 commits into
masterfrom
readme

Conversation

@clue

@clueclue commented Jul 5, 2015

Copy link
Copy Markdown
Member

Closes#14

@clue

clue commented Jul 5, 2015

Copy link
Copy Markdown
MemberAuthor

Note that this also describes the cancellation feature from PR #13, so we have to wait for that PR to land first.

@clueclue mentioned this pull request Jul 5, 2015
Comment threadREADME.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For React/Promise >= 2.2 this can be:

Timer\timeout($promise, 10.0, $loop)
->then(function ($value) {
// the operation finished within 10.0 seconds
})
->otherwise(function (Timer\TimeoutException$error) {
// the operation has failed due to a timeout
})
->otherwise(function ($error) {
// the input operation has failed due to some other error
})
;

Note that i intentionally omitted rethrowing the exception.

@clue

clue commented Jul 5, 2015

Copy link
Copy Markdown
MemberAuthor

Note that this also describes the cancellation feature from PR #13, so we have to wait for that PR to land first.

I've just removed this and force-pushed an update without the cancellation feature.

I'm aiming to get this in soon, while the cancellation feature may still take some time.

@clue

clue commented Jul 5, 2015

Copy link
Copy Markdown
MemberAuthor

Ping @jsor

@jsor

jsor commented Jul 5, 2015

Copy link
Copy Markdown
Member

LGTM :shipit:

clue added a commit that referenced this pull request Jul 5, 2015
@clue
clue merged commit 0f5a7fd into masterJul 5, 2015
@clue
clue deleted the readme branch July 5, 2015 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@jsor