Skip to content

Revert follower cancellation propagation (#99) - #122

Merged
WyriHaximus merged 1 commit into
reactphp:2.xfrom
clue-labs:revert-cancellation-propagation
Jun 8, 2018
Merged

Revert follower cancellation propagation (#99)#122
WyriHaximus merged 1 commit into
reactphp:2.xfrom
clue-labs:revert-cancellation-propagation

Conversation

@clue

@clueclue commented Jun 8, 2018

Copy link
Copy Markdown
Member

This PR reverts follower cancellation propagation as implemented in #99. After discussing this feature with @jsor we agreed that the concept makes perfect sense, but the implementation is currently incomplete and also doesn't quite fit the scope of the v2.6 release right now. As such, we agreed to revert these changes for now and re-consider this for a future version instead.

@clueclue added this to the v2.6.0 milestone Jun 8, 2018
jsor
jsor approved these changes Jun 8, 2018
@WyriHaximus
WyriHaximus merged commit 8361389 into reactphp:2.xJun 8, 2018
@clue
clue deleted the revert-cancellation-propagation branch June 8, 2018 14:41
@clueclue mentioned this pull request Jun 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus