Skip to content

Port memory improvements from 2.x to master - #150

Merged
jsor merged 9 commits into
reactphp:masterfrom
WyriHaximus-secret-labs:port-memory-improvements-from-2.x
Dec 2, 2019
Merged

Port memory improvements from 2.x to master#150
jsor merged 9 commits into
reactphp:masterfrom
WyriHaximus-secret-labs:port-memory-improvements-from-2.x

Conversation

@WyriHaximus

@WyriHaximusWyriHaximus commented Nov 23, 2019

Copy link
Copy Markdown
Member

Cherry picked and ported the following PR commits targeting 2.x into this PR to port the memory improvements from them into 3.x: #113, #115, #116, #117, #118, #119, #123, #124

@WyriHaximus
WyriHaximusforce-pushed the port-memory-improvements-from-2.x branch 3 times, most recently from b76a4e4 to e5312e4CompareNovember 23, 2019 21:40
@WyriHaximus
WyriHaximus requested review from clue and jsorNovember 23, 2019 22:09
@WyriHaximusWyriHaximus changed the title [WIP] Port memory improvements from 2.x to masterPort memory improvements from 2.x to masterNov 23, 2019
@WyriHaximusWyriHaximus added this to the v3.0.0 milestone Nov 23, 2019

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Thanks for taking a look at this! Direction seems good, but some changes seem to be missing, can you take a look at this? 👍

Comment threadsrc/Promise.php Outdated
Comment threadsrc/Promise.php Outdated
@WyriHaximus
WyriHaximusforce-pushed the port-memory-improvements-from-2.x branch from d6cdc7b to afb3276CompareNovember 28, 2019 07:40
clue
clue approved these changes Dec 2, 2019

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Changes LGTM, thank you for looking into this! :shipit: 🎉

jsor
jsor approved these changes Dec 2, 2019
@jsor
jsor merged commit 1ca77e9 into reactphp:masterDec 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@jsor@clue