Uh oh!
There was an error while loading. Please reload this page.
Run tests on PHP 7.4 and simplify test matrix - #439
Conversation
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the It can not be reproduced when running on any other PHP version, when This means the test failure is bogus. |
The build error on PHP 7.4 will be addressed via reactphp/dns#164. Interestingly, it fails in the `FunctionalResolverTest` class and does not fail anymore by excluding some other test cases. It can only be reproduced by running: ``` $ vendor/bin/phpunit --coverage-text --exclude-group internet ``` It can not be reproduced when running on any other PHP version, when `ext-xdebug` is disabled, when coverage is not collected or when not excluding this group. This means the test failure is bogus. We work around this by temporarily skipping some test case for now.
clue
commented
Jul 10, 2020
I don' want to hold this PR back due to a bogus build error, so let's work around this by temporarily skipping some test cases for now. This is similar to the work around in #428 and can be reverted once reactphp/dns#164 is released in a future version. PR is ready for review |
Builds on top of reactphp/socket#208, reactphp/dns#156, reactphp/promise-timer#41 and others.
Supersedes / closes#436