Skip to content

Work around Unix domain socket (UDS) paths for Mac OS X - #123

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
andig:php74556
Oct 7, 2017
Merged

Work around Unix domain socket (UDS) paths for Mac OS X#123
WyriHaximus merged 1 commit into
reactphp:masterfrom
andig:php74556

Conversation

@andig

@andigandig commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

This is an improvement over #92 that handles the new OSX-specific failure introduced by the initial fix for https://bugs.php.net/bug.php?id=74556.

@andigandig mentioned this pull request Oct 7, 2017
Closed
andig added a commit to andig/php-pm that referenced this pull request Oct 7, 2017
@andig
OSX fix untilreactphp/socket#123has been released
316be1e
@clueclue added this to the v0.8.5 milestone Oct 7, 2017
@clueclue changed the title Address OSX-specific PHP bug 74556Fix Unix domain socket (UDS) paths for Mac OS XOct 7, 2017
clue
clue approved these changes Oct 7, 2017
View reviewed changes

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting, reporting this upstream and filing this here! LGTM, let's get this in :shipit:

jsor
jsor approved these changes Oct 7, 2017
View reviewed changes
@clue

clue commented Oct 7, 2017

Copy link
Copy Markdown
Member

For the reference: This fix builds on top of #100 which landed in v0.8.0. Both are actually work-arounds for bugs in PHP, the first of which has been fixed in PHP 7.1.7 and the second has just been merged today and is due in the next PHP release.

WyriHaximus
WyriHaximus approved these changes Oct 7, 2017
View reviewed changes

@WyriHaximusWyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WyriHaximus
WyriHaximus merged commit e621ea2 into reactphp:masterOct 7, 2017
@andig
andig deleted the php74556 branch October 7, 2017 20:02
@jsorjsor mentioned this pull request Oct 7, 2017
Closed
@andig

andig commented Oct 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Would it be possible to release this as soon as possible? Would be nice to get UDS support into the wild without depending on dev-master.

@clueclue changed the title Fix Unix domain socket (UDS) paths for Mac OS XWork around Unix domain socket (UDS) paths for Mac OS XOct 23, 2017
@clue

clue commented Nov 9, 2017

Copy link
Copy Markdown
Member

For the reference: This work-around is no longer required in PHP versions 7.0.25+ and 7.1.11+ now that the fix is in via php/php-src@843e492. This work-around does no harm and we'll keep this to support older PHP versions 👍

@WyriHaximus

WyriHaximus commented Nov 19, 2017

Copy link
Copy Markdown
Member

@andig FYI https://github.com/reactphp/socket/releases/tag/v0.8.6 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsorjsorjsor approved these changes
@WyriHaximusWyriHaximusWyriHaximus approved these changes
@clueclueclue approved these changes

Assignees

No one assigned

Labels

bugeasy pickhelp wanted

Projects

None yet

Milestone

v0.8.5

Development

Successfully merging this pull request may close these issues.

4 participants

@andig@clue@WyriHaximus@jsor