Uh oh!
There was an error while loading. Please reload this page.
Use GitHub actions for continuous integration (CI) - #254
Merged
Conversation
clue
reviewed
Feb 25, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bye bye Travis CI, you've served us well.
SimonFringsforce-pushed
the
ci
branch
2 times, most recently
from
March 29, 2021 09:37
75c2e32 to
644575eCompareclue
approved these changes
Mar 31, 2021
clue
left a comment
Member
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
WyriHaximus
approved these changes
Apr 3, 2021
jsor
approved these changes
Apr 5, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bye bye Travis CI, you've served us well.
@clue and I are currently working on switching from Travis to GitHub actions in all ReactPHP repositories.
I've built a little workaround for some tests for legacy PHP. When using recursion there is always the risk of reaching a full stack which results in PHP failing hard. Therefore the
max_nesting_levelsetting from Xdebug (to prevent reaching this point) was set to 100 for PHP Versions < 5.4 which resulted in failing test for legacy PHP. In 2015 this setting was changed to 256 for PHP Versions > 5.4. For more details look into Xdebug#1100This code supports running tests on PHP 8.
Builds on top of #243 and reactphp/reactphp#442.