Uh oh!
There was an error while loading. Please reload this page.
Check for empty socket address - #93
Conversation
clue
commented
Apr 17, 2017
@andig Thanks for taking the time to file this PR! 👍 Unfortunately, the PR does not contain any documentation or tests, so it's a bit unclear what you're trying to achieve from the snippet you've posted. May I ask you provide a simple gist of what you're trying to achieve, i.e. how can this be reproduced and how can we be sure this issue is actually resolved and we do not introduce any regressions in the future? Thanks! |
andig
commented
Apr 17, 2017
This happens from inside our application. Unfortunately I cannot produce a simple gist. Looking at lxr I believe returning the NULL string is what PHP does- under which condition whatsoever. I've added comment to the code what the check is supposed to do. There was no parseAddress test before and I have unfortunately no clue how to write one- sorry. |
Add main Connector facade
andig
commented
May 8, 2017
Thanks for fixing. Now- for sake of documentation- I understand that the observed behaviour happens with UNIX domain sockets. |
Fix#92