Skip to content

Add .gitattributes to exclude dev files from exports - #144

Merged
clue merged 1 commit into
reactphp:masterfrom
reedy:gitattributes
Dec 21, 2019
Merged

Add .gitattributes to exclude dev files from exports#144
clue merged 1 commit into
reactphp:masterfrom
reedy:gitattributes

Conversation

@reedy

@reedyreedy commented Dec 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

As per discussion at reactphp/promise#153

@reedyreedy changed the title Create .gitattributesAdd .gitattributes to exclude dev files from exportsDec 1, 2019
@WyriHaximusWyriHaximus added this to the v1.1.1 milestone Dec 2, 2019
clue
clue reviewed Dec 2, 2019
View reviewed changes

@clueclue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reedy This PR seems to contain some unrelated changes (and has strange commit authorship). The changes may make sense, but may I ask you to not mix this into this PR and file a dedicated PR if deemed useful? 👍

WyriHaximus
WyriHaximus approved these changes Dec 20, 2019
View reviewed changes

@WyriHaximusWyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@clue
clue merged commit 2b9e19d into reactphp:masterDec 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsorjsorjsor approved these changes
@WyriHaximusWyriHaximusWyriHaximus approved these changes
@clueclueclue approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@reedy@jsor@WyriHaximus@clue