Skip to content

Simplify usage by supporting new default loop - #159

Merged
clue merged 2 commits into
reactphp:masterfrom
clue-labs:default-loop
Jul 11, 2021
Merged

Simplify usage by supporting new default loop#159
clue merged 2 commits into
reactphp:masterfrom
clue-labs:default-loop

Conversation

@clue

@clueclue commented Jul 5, 2021

Copy link
Copy Markdown
Member

This changeset simplifies usage by supporting the new default loop.

// old (still supported)$stream = newReadableResourceStream($resource, $loop);
$stream = newWritabeResourceStream($resource, $loop);
$stream = newDuplexResourceStream($resource, $loop);
// new (using default loop)$stream = newReadableResourceStream($resource);
$stream = newWritabeResourceStream($resource);
$stream = newDuplexResourceStream($resource);

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229 and reactphp/event-loop#232

@clueclue added this to the v1.2.0 milestone Jul 5, 2021
@clue

clue commented Jul 5, 2021

Copy link
Copy Markdown
MemberAuthor

The first commit updates this to the currently unreleased EventLoop component to show how the new default loop can be used in this component (the build should be green). The second commit updates this to the release that has yet to be tagged. This is expected to fail at the moment and should be green once the release is tagged and the build is restarted.

This is ready for review. I will restart the build and merge once reviewed and the EventLoop component is tagged.

@clueclue changed the title [WIP] Simplify usage by supporting new default loopSimplify usage by supporting new default loopJul 11, 2021
@clue

clue commented Jul 11, 2021

Copy link
Copy Markdown
MemberAuthor

Restarted build and everyhing's green now that reactphp/event-loop v1.2.0 has been released :shipit:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@WyriHaximus