Skip to content

Add native types to public API - #178

Merged
WyriHaximus merged 1 commit into
reactphp:3.xfrom
clue-labs:types
May 19, 2024
Merged

Add native types to public API#178
WyriHaximus merged 1 commit into
reactphp:3.xfrom
clue-labs:types

Conversation

@clue

@clueclue commented May 17, 2024

Copy link
Copy Markdown
Member

This changeset adds native types to the public API as discussed in #173.

Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types.

Builds on top of #177, #175 and reactphp/cache#60

@SimonFringsSimonFrings left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@WyriHaximus
WyriHaximus merged commit cf107f5 into reactphp:3.xMay 19, 2024
@clue
clue deleted the types branch May 19, 2024 19:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@WyriHaximus@SimonFrings