Remove BufferedSink

[clue]

This ticket aims to serve as a discussion basis whether this class should actually be part of this repository.

Bridging between Stream-land and Promise-land is arguably out of scope for basic streams. Also, this happens to be the only class that has an "optional dependency" on promises. Full promise support would also involve proper cancellation support, stricter promise version checks and much more…

As an alternative, I would suggest making https://github.com/clue/php-promise-stream-react an official react repo and redirect there.

Builds on top of #44, also solves #24.

[WyriHaximus]

I'm in favor of both suggestions, also I assume this is for 0.5 then?

[clue]

I assume this is for 0.5 then

Yeah, this obviously involves a BC break and should target the v0.5 release.

[WyriHaximus]

I assume this is for 0.5 then

Yeah, this obviously involves a BC break and should target the v0.5 release.

As long as https://github.com/clue/php-promise-stream-react becomes an official repo 👍 from me

[jsor]

I assume this is for 0.5 then

Yeah, this obviously involves a BC break and should target the v0.5 release.

As long as https://github.com/clue/php-promise-stream-react becomes an official repo 👍 from me

👍

[clue]

Rebased to remove merge conflicts now that #44 is in. This is currently planned for the future v0.5.0 release.

[clue]

Rebased on current master

I'd like to get this in for the next release so we can get the v1.0.0 release out and then later look into providing an "official" replacement. In the meantime, https://github.com/clue/php-promise-stream-react works just fine 👍

[WyriHaximus]

In the meantime, https://github.com/clue/php-promise-stream-react works just fine 👍

How about we move that to an official repo and package? It looks good to me 👍 . Preferable before merging this/releasing this change.

[clue]

In the meantime, https://github.com/clue/php-promise-stream-react works just fine 👍

How about we move that to an official repo and package?

I'm not opposed to this, but would rather focus our efforts on the main components first and then look into this? 👍

[WyriHaximus]

In the meantime, https://github.com/clue/php-promise-stream-react works just fine 👍

How about we move that to an official repo and package?

I'm not opposed to this, but would rather focus our efforts on the main components first and then look into this? 👍

Agreed, mainly wanted to point out that I think it is a bad plan to remove this without official replacement 😄

[clue]

For the reference: The buffer() function is now part of react/promise-stream.