Uh oh!
There was an error while loading. Please reload this page.
Simplify and improve error handling - #56
Merged
Merged
Conversation
clueforce-pushed
the
faster-buffer-errors
branch
2 times, most recently
from
August 22, 2016 12:21
fc7161b to
0a4913fCompareclueforce-pushed
the
faster-buffer-errors
branch
from
August 22, 2016 22:01
0a4913f to
bcdfe75CompareDo not construct ErrorException from within error handler
clue
commented
Aug 22, 2016
MemberAuthor
Rebased now that #52 is in. Ready for review |
WyriHaximus
commented
Aug 22, 2016
Member
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only cleans up some of the internals and avoids some unnecessary function calls.
Running the examples/benchmark-throughput.php script, this change alone increases performance from ~100 MiB/s to ~120 MiB/s on my (rather mediocre) test system, using PHP 7.0.8.
Combined with #53, #54 and #55, it increases performance from ~100 MiB/s to ~2000 MiB/s.
If you want to review, consider looking at the individual commits, this should make the changes pretty obvious.
Marking this as WIP because this will need to be rebased once #52 is in.Edit: done.