Uh oh!
There was an error while loading. Please reload this page.
docs: mark wave 3 done; add wave 4 provider registry overhaul plan (#13, #21) - #39
docs: mark wave 3 done; add wave 4 provider registry overhaul plan (#13, #21)#39AndresL230 wants to merge 9 commits into
Conversation
- CLAUDE.md: update registry contract to reflect specificity-sorted rules with custom-wins-on-tie (the PR intentionally moved away from unconditional custom-prepended priority to stop custom catch-alls shadowing built-in path-specific rules) - plan doc: use 4-backtick outer fences around the README-replacement blocks so the nested ```ts examples parse correctly, and tag the expected-commit-list block as ```text to satisfy MD040
📝 WalkthroughWalkthroughThis PR implements the complete Wave 4 plan for provider registry and aggregator correctness improvements: specificity-based rule ordering (preventing custom catch-alls from shadowing built-ins), normalized catch-all endpointCategory ("other" instead of raw pathname), ingest-time soft bucket cap with overflow bucketing and tracking, and coordinated documentation updates. ChangesWave 4 Implementation: Registry Specificity & Aggregator Cap
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/superpowers/plans/2026-05-15-provider-registry-overhaul.md (1)
71-86: ⚡ Quick winMake command examples repo-relative instead of machine-specific absolute paths.
The hardcoded
/home/andresl/...paths make the plan non-reproducible for other contributors. Prefer$REPO_ROOT,git rev-parse --show-toplevel, or purely relative paths in all command snippets.Also applies to: 97-99
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/superpowers/plans/2026-05-15-provider-registry-overhaul.md` around lines 71 - 86, Replace machine-specific absolute paths in the plan's command examples (e.g., the "git -C /home/andresl/Projects/recost/middleware-node worktree list" and the series of commands that cd into "/home/andresl/Projects/recost/middleware-node" and ".claude/worktrees/...") with repo-relative variants; use a variable like $REPO_ROOT, a one-liner to compute the repo root (git rev-parse --show-toplevel), or purely relative paths (./) and update the git worktree add and cd examples accordingly so contributors can run the steps from any environment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/superpowers/plans/2026-05-15-provider-registry-overhaul.md`:
- Around line 71-86: Replace machine-specific absolute paths in the plan's
command examples (e.g., the "git -C
/home/andresl/Projects/recost/middleware-node worktree list" and the series of
commands that cd into "/home/andresl/Projects/recost/middleware-node" and
".claude/worktrees/...") with repo-relative variants; use a variable like
$REPO_ROOT, a one-liner to compute the repo root (git rev-parse
--show-toplevel), or purely relative paths (./) and update the git worktree add
and cd examples accordingly so contributors can run the steps from any
environment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cd7576d0-6e03-4784-bcdb-0bdf3573bd22
📒 Files selected for processing (8)
CLAUDE.mdREADME.mddocs/superpowers/plans/2026-05-15-provider-registry-overhaul.mddocs/superpowers/roadmap-2026-05-13-issue-waves.mdsrc/core/aggregator.tssrc/core/provider-registry.tstests/aggregator.test.tstests/provider-registry.test.ts
https://claude.ai/code/session_01K4tepaje9rv5Z2HX1hHU4u
Summary by CodeRabbit
New Features
overflowCountmetric when bucket capacity limits are reachedImprovements
Documentation